allow new restriction for JourneyPart

[ue71603]

Currently it can be time and ScheduledStopPoints. But it should be StopPointInJourneyPattern as well.

[skinkie]

@ue71603 i want to discuss the part 'if absent' is there a real reason to have a journey part of a single stop?

[ue71603]

@ue71603 i want to discuss the part 'if absent' is there a real reason to have a journey part of a single stop?
We could change it to: means the reminder of the ServiceJourney. if you insist and @duexw is happy, I will remove the minOccurs ...

[skinkie]

@ue71603 and notice that the two sequences are not correct in the choice.

[ue71603]

@ue71603 and notice that the two sequences are not correct in the choice.

What do you mean about choice and sequences?

[ue71603]

@thbar Also here, why is this blocked? the branch is synchronised with 2.1-wip

[thbar]

@thbar Also here, why is this blocked? the branch is synchronised with 2.1-wip

Looking into it.

[thbar]

@thbar Also here, why is this blocked? the branch is synchronised with 2.1-wip

I think I found the cause, and it's unrelated to the parent check etc. Basically, the "lint" auto-commit step does not use a GitHub token allowing to trigger the workflows. So if the "lint" step is the last thing on the PR, then .... the status checks never run.

This is shown by the lack of green check here:

The temporary workaround I'm suggesting is to push an empty commit as "you".

Will document this in an issue, I have no idea if this is new or not, but at least you have a workaround now. A second review will allow you to merge here.

[thbar]

Bug opened at #1037