chore(tests): retire obsolete TCP integration fixtures

[yordis]

• Removes integration fixtures that only exercised the retired transport.

[cursor]

PR Summary

Low Risk
Test-only deletions with no runtime behavior changes; main risk is reduced regression coverage for retired TCP paths unless equivalent tests exist elsewhere.

Overview
Deletes a large batch of test-only fixtures that targeted the retired TCP client transport and related integration scenarios—no production code changes.

Removed coverage includes TCP connection/dispatcher behavior (TcpClientDispatcherTests, TcpConnectionManagerTests), low-level TCP/SSL connection lifecycle tests, certificate chain handshake checks, cluster integration for leader election with unindexed data, and the copying_metadata StreamMetadata copy tests. Some narrower TCP tests (e.g. core_tcp_package, SSL plugin fixtures) remain in the tree.

^{Reviewed by Cursor Bugbot for commit c0537ba. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2fc1a091-d7fc-4414-9e7b-ce9689f106bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d60a3deb-5238-4344-bf3a-d1e87e64a096

📥 Commits

Reviewing files that changed from the base of the PR and between d9fd258 and 2d332c1.

📒 Files selected for processing (8)

• src/EventStore.Core.Tests/Integration/when_node_becomes_leader_with_unindexed_data.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpClientDispatcherTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionManagerTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionSslTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/when_invalid_data_is_sent_over_tcp.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/with_intermediate_certificates.cs
• src/EventStore.Core.Tests/copying_metadata.cs

💤 Files with no reviewable changes (8)

• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpClientDispatcherTests.cs
• src/EventStore.Core.Tests/copying_metadata.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionSslTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/when_invalid_data_is_sent_over_tcp.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/with_intermediate_certificates.cs
• src/EventStore.Core.Tests/Integration/when_node_becomes_leader_with_unindexed_data.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionManagerTests.cs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The pull request deletes eight test files. The removed tests covered cluster leader changes, TCP transport behavior, certificate handshakes, and StreamMetadata copying.

Changes

Cluster integration test removal

Layer / File(s)	Summary
Leader transition coverage removal src/EventStore.Core.Tests/Integration/when_node_becomes_leader_with_unindexed_data.cs	Removes the cluster test for leader changes, quorum timeouts, recovery, replication, and event revision checks.

TCP test removal

Layer / File(s)	Summary
TCP message dispatch coverage removal src/EventStore.Core.Tests/Services/Transport/Tcp/TcpClientDispatcherTests.cs	Removes tests for V2 client message wrapping and scavenge response handling.
TCP connection and certificate coverage removal src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionManagerTests.cs, src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionSslTests.cs, src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionTests.cs, src/EventStore.Core.Tests/Services/Transport/Tcp/when_invalid_data_is_sent_over_tcp.cs, src/EventStore.Core.Tests/Services/Transport/Tcp/with_intermediate_certificates.cs	Removes tests for connection queues, closure and disposal, invalid TCP data, and intermediate-certificate handshakes.

Metadata test removal

Layer / File(s)	Summary
Metadata copying coverage removal src/EventStore.Core.Tests/copying_metadata.cs	Removes tests for copying empty and populated metadata and mutating copied metadata.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 99892

No concrete merge-blocking risk remains established for this fixture-removal change.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately identifies the primary change: removal of obsolete TCP integration test fixtures. It is concise and specific, although it does not mention the additional non-TCP test deletions.
Description check	✅ Passed	The description directly relates to the changes by stating that obsolete transport integration fixtures were removed.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch yordis/chore-retire-core-tcp-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit hops through deleted tests
The cluster paths grow quiet
TCP echoes fade away
Metadata leaves no footprints
Eight files rest beneath the moon}

_{Comment @coderabbitai help to get the list of available commands.}