Skip to content

chore(docs): clarify the supported gRPC network boundary - #499

Open
yordis wants to merge 1 commit into
yordis/chore-remove-legacy-tcp-packagefrom
yordis/chore-document-grpc-networking
Open

yordis wants to merge 1 commit into
yordis/chore-remove-legacy-tcp-packagefrom
yordis/chore-document-grpc-networking

Conversation

@yordis

@yordis yordis commented Sep 12, 2026

Copy link
Copy Markdown
Member
  • Keeps deployment, operator, and migration guidance aligned with the supported network topology and honest TestClient capabilities.

@yordis
yordis requested a review from a team as a code owner September 12, 2026 23:22
@yordis
yordis added this pull request to stack #500 September 12, 2026 23:22
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Mostly documentation and sample/CI alignment; Dockerfile port exposure and Compose env vars could affect operators who relied on the old documented TCP topology or incorrect EXPOSE metadata.

Overview
This PR re-documents TrogonEventStore’s supported network model: database clients, gossip/elections, and follower-to-leader forwarding use gRPC on the node HTTP(S) endpoint; replication uses gRPC on a separate replication HTTP(S) listener; there is no legacy EventStore TCP client or replication protocol. Architecture, networking, cluster, security, installation, upgrade, Admin UI, and diagnostics pages are updated to match, including Monitoring.ConnectionStats / Monitoring.ReplicationStats (and removal of TCP-oriented stats/Monitoring.TcpStats from the contract) and upgrade/TestClient guidance for retired TCP commands and protos.

Deployment and CI changes set explicit EVENTSTORE_NODE_IP in local cluster Compose files, drop the test image CA cert copy from the Dockerfile, fix runtime EXPOSE to 1112 + 2113, trim .gitignore for ClientAPI assembly version, and adjust scripts/test.sh to stop routing TCP API test plugin suites and give core-services a longer timeout.

Reviewed by Cursor Bugbot for commit 5d0be15. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4adb3c23-885e-40aa-84da-adc5be80cf5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 844ddd1. Configure here.

Comment thread docker-compose.yml
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e32fdab to eb57a53 Compare September 13, 2026 00:15
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from e64b0cd to f4615e2 Compare September 13, 2026 00:33
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from eb57a53 to aecb79b Compare September 13, 2026 00:33
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from f4615e2 to bf1b1ee Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from aecb79b to 6c8c952 Compare September 13, 2026 00:58
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from bf1b1ee to 6b3dfea Compare September 13, 2026 01:16
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 6c8c952 to b59fac7 Compare September 13, 2026 01:16
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 6b3dfea to edabfbe Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from b59fac7 to e2ed620 Compare September 13, 2026 01:31
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from edabfbe to 815e085 Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e2ed620 to 75e1a84 Compare September 13, 2026 01:46
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 815e085 to 4fc84c5 Compare September 13, 2026 02:04
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from 2b3ea9b to 55dbee6 Compare September 13, 2026 02:29
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from 523f6c0 to b247e43 Compare September 13, 2026 02:59
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from 1a6764d to bc7052f Compare September 13, 2026 03:14
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from b247e43 to 8ab3833 Compare September 13, 2026 03:14
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from bc7052f to bc1674b Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 8ab3833 to 4c3d9cd Compare September 13, 2026 03:46
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from bc1674b to a6da954 Compare September 13, 2026 04:23
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 4c3d9cd to 103037b Compare September 13, 2026 04:23
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from e4379ed to d91f707 Compare September 13, 2026 21:00
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 38edb52 to 39a8db8 Compare September 13, 2026 21:00
@yordis
yordis removed this pull request from stack #500 September 17, 2026 01:12
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 39a8db8 to 8c82a62 Compare September 17, 2026 01:14
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from 0db3383 to 9d887da Compare September 17, 2026 01:23
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from 11ee068 to f0042a1 Compare September 17, 2026 02:01
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 9d887da to 4d8615e Compare September 17, 2026 02:01
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from f0042a1 to c4bb749 Compare September 17, 2026 02:37
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 4d8615e to cd8e4e4 Compare September 17, 2026 02:37
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from c4bb749 to 8b4cd00 Compare September 17, 2026 03:26
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from cd8e4e4 to f9ff215 Compare September 17, 2026 03:26
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 8b4cd00 to 7d1e3b4 Compare September 17, 2026 04:25
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from f9ff215 to 56ec3bf Compare September 17, 2026 04:25
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 7d1e3b4 to 98caa26 Compare September 17, 2026 22:47
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from 2bd1130 to a53fd31 Compare September 17, 2026 22:57
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch 2 times, most recently from 569dd1e to bb5d1f0 Compare September 17, 2026 23:43
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from a53fd31 to fea4246 Compare September 17, 2026 23:43
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from bb5d1f0 to fa7b8b5 Compare September 18, 2026 00:26
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch 2 times, most recently from 9495ea5 to a05dab8 Compare September 18, 2026 00:44
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from fa7b8b5 to e4ecb11 Compare September 18, 2026 00:44
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from a05dab8 to 815d9c9 Compare September 18, 2026 00:49
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from e4ecb11 to 5268346 Compare September 18, 2026 00:49
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/chore-remove-legacy-tcp-package branch from 5268346 to 8d3a13b Compare September 18, 2026 01:43
@yordis
yordis force-pushed the yordis/chore-document-grpc-networking branch from 815d9c9 to 5d0be15 Compare September 18, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant