Skip to content

test(server): one copy of the viewed-files tests, not two - #50

Merged
yordis merged 1 commit into
mainfrom
yordis/test-drop-duplicated-viewed-files-tests
Sep 17, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/test-drop-duplicated-viewed-files-tests

Conversation

@yordis

@yordis yordis commented Sep 17, 2026

Copy link
Copy Markdown
Member
  • A sync left the viewed-files block in the file twice, and the duplicate has been failing CI on main ever since.
  • Both copies share the node id cache, so the stale one asks about a pull request the surviving copy already cached and then fails on the round trip it no longer makes.
  • Upstream carries a single copy, so this is the fork catching up rather than a behavior change.

A sync left the block in twice. Both copies share the node id cache, so the stale one asks for a pull request the surviving copy already cached and fails on the round trip it no longer makes.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b6d4108f-0dee-4632-ae45-82370e81683f

📥 Commits

Reviewing files that changed from the base of the PR and between 4b5ff06 and db44f3a.

📒 Files selected for processing (1)
  • apps/server/src/pullRequest/GitHubPullRequestCli.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only deletion of redundant cases; no runtime code paths are modified.

Overview
Removes a duplicate block of four it.effect cases in GitHubPullRequestCli.test.ts for pull-request viewed-files behavior (multi-page getPullRequestFilesViewed, pagination cap, batched setPullRequestFilesViewed, and no-op when files is empty).

The same scenarios remain covered by the surviving copy later in the file, so this is CI/test hygiene only—no production or API behavior change.

Reviewed by Cursor Bugbot for commit db44f3a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.2 KiB 13.5 KiB +370 B (+2.7%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 7.1 KiB +171 B (+2.4%) 7.3 KiB
Codex Live turn WebSocket wire 6.2 KiB 6.4 KiB +199 B (+3.1%) 7.8 KiB
Codex Live turn WebSocket decoded 54.7 KiB 56.2 KiB +1.5 KiB (+2.8%) 66.4 KiB
Codex Live turn messages 8 9 +1 (+12.5%) 21
Claude Total thread wire 13.2 KiB 13.5 KiB +343 B (+2.5%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 7.1 KiB +162 B (+2.3%) 7.3 KiB
Claude Live turn WebSocket wire 6.3 KiB 6.4 KiB +181 B (+2.8%) 7.8 KiB
Claude Live turn WebSocket decoded 55.5 KiB 57.0 KiB +1.5 KiB (+2.8%) 66.4 KiB
Claude Live turn messages 8 9 +1 (+12.5%) 21

Baseline: eb6fcb3 · PR result: db44f3a · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit 871b68d into main Sep 17, 2026
17 of 19 checks passed
@yordis
yordis deleted the yordis/test-drop-duplicated-viewed-files-tests branch September 17, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant