chore: keep internal helpers out of the public surface - #51
Conversation
The unused-code check has been red on main because these are reachable from outside the file that uses them, and two had no caller left at all. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR SummaryLow Risk Overview Removes dead entry points with no callers: the Reviewed by Cursor Bugbot for commit 45e3808. Bugbot is set up for automated code reviews on this repo. Configure here. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
main: every one of these is exported where nothing outside its own file reads it, so the check is right to complain.ForkMigrationsLiveand the client tracing test reset had no caller at all. Fork migrations run from the sqlite layer directly, and no test ever reached for the reset, so both are gone rather than exported into the dark.