Skip to content

chore: keep internal helpers out of the public surface - #51

Merged
yordis merged 1 commit into
mainfrom
yordis/chore-unexport-internal-symbols
Sep 17, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/chore-unexport-internal-symbols

Conversation

@yordis

@yordis yordis commented Sep 17, 2026

Copy link
Copy Markdown
Member
  • The unused-code check has been failing on main: every one of these is exported where nothing outside its own file reads it, so the check is right to complain.
  • ForkMigrationsLive and the client tracing test reset had no caller at all. Fork migrations run from the sqlite layer directly, and no test ever reached for the reset, so both are gone rather than exported into the dark.

The unused-code check has been red on main because these are reachable from outside the file that uses them, and two had no caller left at all.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d60249cf-6f2e-4268-85db-1e1c1a3cd508

📥 Commits

Reviewing files that changed from the base of the PR and between 4b5ff06 and 45e3808.

📒 Files selected for processing (9)
  • apps/server/src/mcp/McpHttpServer.ts
  • apps/server/src/mcp/toolkits/threads/tools.ts
  • apps/server/src/persistence/ForkMigrations.ts
  • apps/server/src/provider/Layers/ClaudeProvider.ts
  • apps/server/src/provider/ProviderSecretReference.ts
  • apps/server/src/provider/Services/ProviderSecretResolver.ts
  • apps/server/src/server.ts
  • apps/web/src/components/ChatView.logic.ts
  • apps/web/src/observability/clientTracing.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Export and dead-code cleanup only; runtime behavior is unchanged aside from removing unused symbols that nothing imported.

Overview
Shrinks the public module surface so the unused-export check passes: helpers that only live inside their file are no longer exported (MCP toolkit registration layers, thread spawn/await tools, route wiring, Claude auth helper, 1Password secret prefix/passthrough resolver, background-work label formatting, and similar).

Removes dead entry points with no callers: the ForkMigrationsLive Effect layer (fork migrations already run from the SQLite persistence layer) and the web client tracing test reset __resetClientTracingForTests. ForkMigrations.ts keeps runForkMigrations and ledger helpers; only the unused layer and extra exports are dropped.

Reviewed by Cursor Bugbot for commit 45e3808. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.2 KiB 13.5 KiB +319 B (+2.4%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 7.1 KiB +165 B (+2.3%) 7.3 KiB
Codex Live turn WebSocket wire 6.2 KiB 6.4 KiB +154 B (+2.4%) 7.8 KiB
Codex Live turn WebSocket decoded 54.7 KiB 56.2 KiB +1.5 KiB (+2.7%) 66.4 KiB
Codex Live turn messages 8 8 0 (0.0%) 21
Claude Total thread wire 13.2 KiB 13.5 KiB +354 B (+2.6%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 7.1 KiB +161 B (+2.3%) 7.3 KiB
Claude Live turn WebSocket wire 6.3 KiB 6.4 KiB +193 B (+3.0%) 7.8 KiB
Claude Live turn WebSocket decoded 55.5 KiB 57.0 KiB +1.5 KiB (+2.8%) 66.4 KiB
Claude Live turn messages 8 9 +1 (+12.5%) 21

Baseline: eb6fcb3 · PR result: 45e3808 · Source CI: cancelled

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit 7eae364 into main Sep 17, 2026
18 of 19 checks passed
@yordis
yordis deleted the yordis/chore-unexport-internal-symbols branch September 17, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant