Skip to content

test(client-runtime): shell snapshot cache test fits CI's timeout - #66

Merged
yordis merged 1 commit into
mainfrom
yordis/test-shell-snapshot-sample-count
Sep 28, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/test-shell-snapshot-sample-count

Conversation

@yordis

@yordis yordis commented Sep 28, 2026 •

Copy link
Copy Markdown
Member
  • The generated-snapshot test takes about 6.4s on CI runners and fails the 5s timeout on every run, which blocks main and every open PR.
  • A tenth of the samples is enough, since the monogram icon, the one field whose encoding differs, is forced rather than left to the generator.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: TrogonStack/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3fd88158-bbc4-400e-99d7-9bd85d9f87c3

📥 Commits

Reviewing files that changed from the base of the PR and between f7bbc6c and 98058b9.

📒 Files selected for processing (1)
  • packages/client-runtime/src/platform/persistence.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Sep 28, 2026
@cursor

cursor Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only change that lowers arbitrary sample count; no production behavior or runtime logic affected.

Overview
Reduces property-test sample volume in encodeShellSnapshotForCache coverage so the suite stays under CI’s 5s timeout (it was ~6.4s with 1000 generated snapshots).

sampleDecoded now draws 100 arbitrary encode/decode round-trips instead of 1000. Coverage intent is unchanged: the test still forces monogram projectIcon values on alternating projects, so the encoding path that differs from the generator does not depend on hitting rare generated shapes.

Reviewed by Cursor Bugbot for commit 98058b9. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB +20 B (+0.1%) 15.1 KiB ✅
Codex Thread snapshot wire 7.1 KiB 7.1 KiB +2 B (+0.0%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.4 KiB 6.5 KiB +18 B (+0.3%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.2 KiB 56.3 KiB +44 B (+0.1%) 66.4 KiB ✅
Codex Live turn messages 9 10 +1 (+11.1%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB −10 B (−0.1%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB −6 B (−0.1%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.4 KiB 6.4 KiB −4 B (−0.1%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: 6fb9f79 · PR result: 98058b9 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 114.0 KiB
  • Claude decoded thread snapshot: 114.7 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yordis
yordis merged commit 70d3890 into main Sep 28, 2026
21 of 22 checks passed
@yordis
yordis deleted the yordis/test-shell-snapshot-sample-count branch September 28, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant