Scoped theme publish permissions (PLA-329) - #586
Draft
9larsons wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shared-theme-assets and theme-translations workflows granted
contents: writeandid-token: writeat workflow scope. Every job inherited those permissions, including tests, dependency installation, and the shared-assets pull-request dry run.PLA-329 limits publish credentials to the jobs that actually publish.
What changed
contents: readcontents: writeandid-token: writeonly to:shared-theme-assets / publishtheme-translations / publishThe publish jobs retain the permissions needed for npm provenance and their existing tag/version commits. No workflow uses
packages: write.Permission audit
Audited all 34 root and embedded theme workflows. The only effective write grants are the two publish jobs above. Every dependency-installing test/build job has no
id-token: write,contents: write, orpackages: write.Validation
actionlinton all embedded theme workflowsactionlint -ignore SC2015(the two excluded SC2015 diagnostics already exist onmainin unchanged translation publish shell logic)corepack pnpm install --frozen-lockfilecorepack pnpm test:ci --theme tastecorepack pnpm buildnpm test --prefix packages/theme-translationsnpm publish --provenance --dry-runfor both npm packagesgit diff --check