Fixing line-overlap missing certain horizontal/vertical lines (#2582)#3071
Open
jonovotny wants to merge 4 commits into
Open
Fixing line-overlap missing certain horizontal/vertical lines (#2582)#3071jonovotny wants to merge 4 commits into
jonovotny wants to merge 4 commits into
Conversation
line-overlap now detects overlap in horizontal and vertical sections with a parallel offset within tolerance. Previously bounding boxes in the rbush tree would not overlap in these edge cases. By expanding the bbox around matching segments by the tolerance this issue is fixed.
mfedderly
requested changes
Jun 26, 2026
mfedderly
left a comment
mfedderly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for looking at this! I think tolerance is in the wrong units but everything else looks good.
|
|
||
| // Expand segment bounding box by the tolerance to create overlap in horizontal/vertical segments | ||
| var bb = bbox(segment); | ||
| bb = [bb[0]-tolerance, bb[1]-tolerance, bb[2]+tolerance, bb[3]+tolerance]; |
Collaborator
There was a problem hiding this comment.
The jsdoc above implies that tolerance is in kilometers not degrees, so this needs a conversion I think.
import { lengthToDegrees} from "@turf/helpers";
...
const toleranceDegrees = lengthToDegrees(tolerance, "kilometers");
Collaborator
There was a problem hiding this comment.
Oh! One other thing. You may want to skip this bbox logic entirely if tolerance === 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line-overlap now detects overlap in horizontal and vertical segments with a parallel offset within tolerance (fixing #2582). Previously bounding boxes in the rbush tree would not overlap in these edge cases. By expanding the bbox around matching segments by the tolerance this issue should be resolved.
Added a test case of two polygons with horizontal and vertical overlap. (#2580 remains a problem and may still lead to missing segments for a different reason.)
Fixes #2582