Skip to content

fix(cli): name the typed invocation in the --assert deprecation warning - #1367

Merged
Chemaclass merged 1 commit into
mainfrom
fix/1366-assert-deprecation-wording
Sep 18, 2026
Merged

Chemaclass merged 1 commit into
mainfrom
fix/1366-assert-deprecation-wording

Conversation

@Chemaclass

Copy link
Copy Markdown
Member

🤔 Background

Related #1366

bashunit -a reaches the deprecated assert path through the inferred test subcommand, so the warning always named bashunit test --assert, a command the user never ran. The deprecation is correct, the wording pointed at the wrong thing.

💡 Changes

  • The warning now quotes the invocation that was typed: bashunit -a, bashunit --assert or bashunit test --assert.
  • The dispatcher records whether the subcommand was typed or inferred, which is what the warning needs to tell those apart.
  • Acceptance tests cover the three spellings.

bashunit -a reaches the deprecated path through the inferred test
subcommand, so the warning always named bashunit test --assert, a
command the user never ran.
@Chemaclass Chemaclass added the bug Something isn't working label Sep 18, 2026
@Chemaclass Chemaclass self-assigned this Sep 18, 2026
@Chemaclass
Chemaclass enabled auto-merge (squash) September 18, 2026 10:11
@Chemaclass
Chemaclass merged commit 3c4b022 into main Sep 18, 2026
37 checks passed
@Chemaclass
Chemaclass deleted the fix/1366-assert-deprecation-wording branch September 18, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants