Repository navigation
Add #pragma once to all headers without an include guard - #726
Merged
Merged
Conversation
Most of Aegisub's own headers had no include guard, so including one twice in a translation unit was a redefinition error. Headers that already have a guard are left alone: the third-party lpeg.h, avisynth.h, gl/glext.h and MatroskaParser.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CoffeeFlux
marked this pull request as ready for review
October 8, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of Aegisub's own headers (161 of them) had no include guard, so including one twice in a translation unit was a redefinition error. Builds only worked because no source file happened to include any of them twice. This also blocks unity builds.
#pragma onceafter the license comment, matching the 47 headers that already used it.#ifndefguard are left alone: the third-partylpeg.h,avisynth.h,gl/glext.handMatroskaParser.h.Tested locally on macOS: builds with PCH on and off, test suites pass, no new warnings.
🤖 Generated with Claude Code