Repository navigation
meson: stop compiling the generated resources twice - #727
Merged
Merged
Conversation
The aegisub executable listed the generated bitmap.cpp and default_config.cpp in its sources even though libresrc, which it links, already compiles them. Only pass the generated headers, which aegisub needs for build ordering. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CoffeeFlux
marked this pull request as ready for review
October 8, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aegisubexecutable listed the generatedbitmap.cppanddefault_config.cppin its sources even thoughlibresrc, which it links, already compiles them. Nowaegisubonly gets the generated headers, which it needs for build ordering.The saving is small (about 1.3s of CPU), but it also makes the link correct in unity builds, where the duplicate objects collided.
Tested locally on macOS: from-scratch builds with PCH on and off, test suites pass, and the binary has the same resource symbols as before.
🤖 Generated with Claude Code