Repository navigation
Fix LayoutResY when resampling with vertical borders - #729
Merged
arch1t3cht merged 1 commit intoOct 8, 2026
Merged
arch1t3cht merged 1 commit into
arch1t3cht merged 1 commit into
Conversation
When adding or removing borders on a script that has a LayoutRes, the new LayoutResY was scaled by the top and bottom margins relative to the source width instead of the source height, giving the wrong LayoutResY whenever the margins were vertical. Introduced in 9f98439. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding or removing borders on a script that has a LayoutRes, the resampler computes the new LayoutResY as
It should divide by
source_y, since LayoutResY needs to grow by the same proportion as PlayResY when top and bottom margins are added. As written, LayoutResY comes out wrong whenever Add/Remove borders (or Manual) produces vertical margins on a non-square script. This was introduced in 9f98439. Horizontal-only margins are unaffected, since then both margins are 0.I haven't built this branch on its own; the change is a single operand, and there are no unit tests covering
src/resolution_resampler.cpp.🤖 Generated with Claude Code