Skip to content

Pre-EKF Robot Localizer Clean up - #3953

Open
StarrryNight wants to merge 24 commits into
masterfrom
samuel/refactor_robot_localizer
Open

StarrryNight wants to merge 24 commits into
masterfrom
samuel/refactor_robot_localizer

Conversation

@StarrryNight

@StarrryNight StarrryNight commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR is the base of the "redesign robot localizer" PR stack. It fixes the following issues:

  1. Add getter functions in primitive executer for previous target velocity, and use that as the control input of the robot localizer
  2. Instead of snapping incoming vision data to the closest step before, we use the actual time of the vision data. This corrects the subsaquent process model and covariances as they depends on elapsed time, dt.
  3. Instead of storing multiple 6x6 matrices in each filter step, we compute the matrices dynamically on rewind. This operation is not expensive as it only involves a multiplications for each matrix.
  4. Instead of using optionals in FilterStep struct and checking for them to determine update/prediction, we store an enum that tells us what type of step this was.
  5. Generate measurement matrix and process matrices with helper functions to improve code quality
  6. Rename several functions for clarity

Testing Done

Resolved Issues

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@StarrryNight
StarrryNight force-pushed the samuel/refactor_robot_localizer branch from 8df03a3 to 90378fc Compare September 13, 2026 02:25
@StarrryNight
StarrryNight added this pull request to stack #3955 September 15, 2026 03:23
@StarrryNight
StarrryNight force-pushed the samuel/refactor_robot_localizer branch from 90378fc to f2e9dd6 Compare September 15, 2026 04:59
@StarrryNight
StarrryNight marked this pull request as ready for review September 15, 2026 05:14
@StarrryNight
StarrryNight force-pushed the samuel/refactor_robot_localizer branch from e18f050 to 90378fc Compare September 16, 2026 05:06
@StarrryNight
StarrryNight force-pushed the samuel/refactor_robot_localizer branch from 2ba21c0 to 0d85f4d Compare September 16, 2026 20:43
@StarrryNight
StarrryNight force-pushed the samuel/refactor_robot_localizer branch from 6133e3c to e462706 Compare September 18, 2026 20:31
Comment thread src/software/embedded/robot_localizer.h Outdated
Comment thread src/software/embedded/robot_localizer_test.cpp Outdated
Comment thread src/software/embedded/robot_localizer.cpp Outdated
Comment thread src/software/embedded/robot_localizer.cpp Outdated
Comment thread src/software/embedded/robot_localizer.cpp
Comment thread src/software/embedded/robot_localizer.cpp
Comment thread src/software/embedded/robot_localizer.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants