Pre-EKF Robot Localizer Clean up - #3953
Open
StarrryNight wants to merge 24 commits into
Open
StarrryNight wants to merge 24 commits into
StarrryNight wants to merge 24 commits into
Conversation
StarrryNight
requested review from
Andrewyx,
nycrat,
sauravbanna and
williamckha
as code owners
September 13, 2026 01:33
StarrryNight
marked this pull request as draft
September 13, 2026 01:33
StarrryNight
force-pushed
the
samuel/refactor_robot_localizer
branch
from
September 13, 2026 02:25
8df03a3 to
90378fc
Compare
StarrryNight
added this pull request to stack #3955
September 15, 2026 03:23
StarrryNight
force-pushed
the
samuel/refactor_robot_localizer
branch
from
September 15, 2026 04:59
90378fc to
f2e9dd6
Compare
StarrryNight
marked this pull request as ready for review
September 15, 2026 05:14
StarrryNight
force-pushed
the
samuel/refactor_robot_localizer
branch
from
September 16, 2026 05:06
e18f050 to
90378fc
Compare
StarrryNight
force-pushed
the
samuel/refactor_robot_localizer
branch
from
September 16, 2026 20:43
2ba21c0 to
0d85f4d
Compare
StarrryNight
force-pushed
the
samuel/refactor_robot_localizer
branch
from
September 18, 2026 20:31
6133e3c to
e462706
Compare
Andrewyx
reviewed
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the base of the "redesign robot localizer" PR stack. It fixes the following issues:
FilterStepstruct and checking for them to determine update/prediction, we store an enum that tells us what type of step this was.Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue