Accumulate lifecycle total loss across events - #145
Merged
Merged
Conversation
StructureTotalLoss and ContentsTotalLoss were assigned each event, so the summary held only the last event's damage. Sum them instead, and assert the totals in TestComputeConsequencesMultiHazard.
The fixture's damages are multiples of 0.5, so the totals are exact in float64 and a tolerance only obscured the check.
trietmnj
marked this pull request as ready for review
September 23, 2026 19:33
HenryGeorgist
self-requested a review
September 23, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeConsequencesMultiHazardassignsStructureTotalLossandContentsTotalLosson every event instead of adding to them, so the lifecycle summary reports only the last event's damage (a DE001 run showed $16.9M against $944.4M summed over its event rows).+=.TestComputeConsequencesMultiHazardnow asserts both totals equal the sum of its five events' damage (67.5; it was 18.0).