Put hades behind an option - #130
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the erik@hades Home Manager configuration so the “hades desktop profile” is controlled by an explicit option, rather than being applied by directly importing the host module in flake.nix.
Changes:
- Adds a
dotfiles.hadestoggle and gates allhades-specific config behind it. - Imports
users/erik/hades.nixfromusers/erik/default.nix, and enables the profile forerik@hadesvia a module override inflake.nix. - Removes
user.signingkeyfrom the shared Git toolchain module.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| users/erik/hades.nix | Introduces a hades profile option and wraps the host-specific configuration in a conditional. |
| users/erik/default.nix | Imports the hades module so its option/config can participate in the erik module graph. |
| toolchain/git/default.nix | Removes the shared Git signing key from the toolchain defaults. |
| flake.nix | Enables the hades profile for erik@hades via an inline module instead of importing the hades module directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+10
| options.dotfiles.hades = lib.mkEnableOption "erik's hades desktop profile"; | ||
|
|
||
| dotfiles = { | ||
| gnome.enable = true; | ||
| brave.enable = true; | ||
| emacs.enable = true; | ||
| vscode.enable = true; | ||
| zed.enable = true; | ||
| helix.enable = true; | ||
| ghostty.enable = true; | ||
| kitty.enable = true; | ||
| containers.enable = true; | ||
| ocaml.enable = true; | ||
| dotnet.enable = true; | ||
| }; | ||
| config = lib.mkIf config.dotfiles.hades { |
| pkgs = legacyPackages.x86_64-linux; | ||
| extraSpecialArgs = { inherit inputs; }; | ||
| modules = modules ++ [ ./users/erik/hades.nix ]; | ||
| modules = modules ++ [ { dotfiles.hades = true; } ]; |
Comment on lines
21
to
25
| user = { | ||
| name = "UnstoppableMango"; | ||
| email = "erik.rasmussen@unmango.dev"; | ||
| signingkey = "264283BBFDC491BC"; | ||
| }; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.