Skip to content

Feature/expand paths - #334

Merged
mpadge merged 4 commits into
UrbanAnalyst:expand-pathsfrom
RegularnaMatrica:feature/expand-paths
Aug 28, 2026
Merged

mpadge merged 4 commits into
UrbanAnalyst:expand-pathsfrom
RegularnaMatrica:feature/expand-paths

Conversation

@RegularnaMatrica

Copy link
Copy Markdown
Contributor

Expands path on contracted graph to the path on full (uncontracted) graph.

@RegularnaMatrica

Copy link
Copy Markdown
Contributor Author

I've looked into uncontract_graph function. Currently it does not keep the order of edges as in contracted graph. I did not change that function, becasue to my understanding it is currently missing graph_full <- graph_full[indx_to_full,], so I'm not certain what the function should do.

Also it seems that edge_map <- get_edge_map(graph) does not keep the order of edges, even though #173 claims it should, thats why I've included sort_transitions˛function.

@codecov

codecov Bot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.28%. Comparing base (c132a22) to head (ef06b20).

Files with missing lines Patch % Lines
R/paths.R 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   93.69%   93.28%   -0.42%     
==========================================
  Files          52       52              
  Lines        6728     6758      +30     
==========================================
  Hits         6304     6304              
- Misses        424      454      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpadge
mpadge changed the base branch from main to expand-paths August 28, 2026 10:49
@mpadge
mpadge merged commit 55e305f into UrbanAnalyst:expand-paths Aug 28, 2026
7 of 9 checks passed
@mpadge

mpadge commented Aug 28, 2026

Copy link
Copy Markdown
Member

@RegularnaMatrica Sorry it took so long to get to this. I've finally merged it (with a few extra tweaks). Because you've added a whole new function, I invite you to submit a PR adding yourself as an author of the package - role = "aut" in https://github.com/UrbanAnalyst/dodgr/blob/main/DESCRIPTION. Thanks!

mpadge added a commit that referenced this pull request Aug 28, 2026
mpadge added a commit that referenced this pull request Aug 29, 2026
mpadge added a commit that referenced this pull request Aug 29, 2026
mpadge added a commit to harrysroberts/dodgr that referenced this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants