type_col in weight_streetnet.sc

[RegularnaMatrica]

Added type_col to weight_streetnet.sc by adding it as parameter to functions weight_sc_edges and set_maxspeed.

[RegularnaMatrica]

this is wrong, here it should use maxspeed

[mpadge]

@RegularnaMatrica Thanks for this, and sorry it's taken me a while to get back to you. Your PR looks like a good abstraction that will improve flexibility here. To clarify what the abstraction of type_col is intended to do, could you please just update function signatures with default values? So replace this:

weight_sc_edges <- function (graph, wt_profile, wt_profile_file, type_col)

with this:

weight_sc_edges <- function (graph, wt_profile, wt_profile_file, type_col = "highway")

Alternatively, if you prefer to avoid duplicating that hard-coded value defined in weight-streetnet.R, could you instead add some documentation to weight_sc_edges just explaining that type_col is defined in weight_streetnet() with a default of "highway".

---

You should also be able to see that the tests currently fail, because one more set_maxspeed() call needs to be updated:

dodgr/R/weight-streetnet.R

Line 398 in b6965ec

graph <- set_maxspeed (graph, wt_profile_name, wt_profile_file) %>%

[mpadge]

@RegularnaMatrica Are you still interested in getting this PR merged? Please let me know; thanks.