fix(loadusers): validate client-reported core stats before caching/persisting - #186
Open
Pajt9whauht283as wants to merge 1 commit into
Open
Conversation
…rsisting Health and stamina values arriving over the network (vorp:SaveHealth, vorp:SaveStamina, vorp:HealthCached) were stored without any type or range checks and flushed to the characters table on save/disconnect, letting a client persist arbitrary values for its own character. Validate at persist time: tonumber + clamp to the 0-100 core range. Rejects non-numeric payloads entirely. Fixes VORPCORE#184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #184 — health/stamina values arriving over the network (
vorp:SaveHealth,vorp:SaveStamina,vorp:HealthCached) were stored without any type or range checks and flushed to thecharacterstable on save/disconnect, letting a modified client persist arbitrary values (e.g. locked max-health snapshots restored on every relogin) or non-numeric garbage that breaks downstream consumers.Per the discussion, this keeps it minimal: no continuous server-side recalculation, just validation at persist time.
Changes
SanitizeCoreValue()helper:tonumber()+ clamp to the 0–100 core rangeHealthOuter(healthOuter - healthInner)is additionally floored at 0 after sanitizing both inputsFixes #184