fix(deps): bump CVE-affected deps [VC-53657, VC-53626]#204
fix(deps): bump CVE-affected deps [VC-53657, VC-53626]#204ndevarapalli-panw wants to merge 3 commits into
Conversation
|
|
||
| bandit -r vcert/ | ||
|
|
||
| # ID 40291 is pip, ignore so we can still test python 2.7 |
There was a problem hiding this comment.
My take here is that you guys are no longer supporting python 2?
| > /tmp/pip-pin.txt && pip install --no-cache-dir --require-hashes -r /tmp/pip-pin.txt | ||
|
|
||
| COPY requirements-build.txt ./ | ||
| COPY docker-entrypoint.sh ./ |
There was a problem hiding this comment.
how is docker-entrypoint.sh being rung in line 13 if its not being copied to the docker coantainer?
There was a problem hiding this comment.
It is being copied, COPY . . on line 11 copies the entire repo root into /usr/src/app, which includes docker-entrypoint.sh. The explicit COPY docker-entrypoint.sh ./ that was in the original Dockerfile was removed because it was a redundant layer COPY . . already covers it.
requirements-build.txt is still copied separately and early (line 8) for Docker layer caching so that the pip install step only re-runs when the lockfile changes, not on every source code change.
|
Added setup.py range constraints in the third commit to address VC-53626 alongside this fix, since we are already modifying the file.
|
Fixes CVEs in
cryptography(→ 48.0.1) andpynacl(→ 1.6.2) across both the lockfile andsetup.py, so published packages are protected too.Also bumps
pytest,pytest-cov,bandit,python-dateutil, andruamel.yamlto their latest Python 3.9-compatible releases.Replaces EOL
safety2.x withpip-audit- same OSV data source, no account required.Also fixes a latent Python 2 idiom (
e.message→str(e)) inpem.pythat would mask key-parsing errors on Python 3.Some CVEs require Python ≥3.10 and are deferred - details in Jira VC-53657. All lockfiles regenerated via
make lockonpython:3.9.Test plan
bandit- cleanpip-audit- deferred findings only (documented in Jira)pytest tests/test_local_methods.py- 35/35 pass