Skip to content

fix(deps): bump CVE-affected deps [VC-53657, VC-53626]#204

Open
ndevarapalli-panw wants to merge 3 commits into
masterfrom
VC-53657-logos-fix
Open

fix(deps): bump CVE-affected deps [VC-53657, VC-53626]#204
ndevarapalli-panw wants to merge 3 commits into
masterfrom
VC-53657-logos-fix

Conversation

@ndevarapalli-panw

@ndevarapalli-panw ndevarapalli-panw commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Fixes CVEs in cryptography (→ 48.0.1) and pynacl (→ 1.6.2) across both the lockfile and setup.py, so published packages are protected too.
Also bumps pytest, pytest-cov, bandit, python-dateutil, and ruamel.yaml to their latest Python 3.9-compatible releases.

Replaces EOL safety 2.x with pip-audit - same OSV data source, no account required.

Also fixes a latent Python 2 idiom (e.messagestr(e)) in pem.py that would mask key-parsing errors on Python 3.

Some CVEs require Python ≥3.10 and are deferred - details in Jira VC-53657. All lockfiles regenerated via make lock on python:3.9.

Test plan

  • bandit - clean
  • pip-audit - deferred findings only (documented in Jira)
  • pytest tests/test_local_methods.py - 35/35 pass
  • Integration tests against live TPP/VaaS

Comment thread docker-entrypoint.sh

bandit -r vcert/

# ID 40291 is pip, ignore so we can still test python 2.7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take here is that you guys are no longer supporting python 2?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment thread Dockerfile
> /tmp/pip-pin.txt && pip install --no-cache-dir --require-hashes -r /tmp/pip-pin.txt

COPY requirements-build.txt ./
COPY docker-entrypoint.sh ./

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is docker-entrypoint.sh being rung in line 13 if its not being copied to the docker coantainer?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being copied, COPY . . on line 11 copies the entire repo root into /usr/src/app, which includes docker-entrypoint.sh. The explicit COPY docker-entrypoint.sh ./ that was in the original Dockerfile was removed because it was a redundant layer COPY . . already covers it.

requirements-build.txt is still copied separately and early (line 8) for Docker layer caching so that the pip install step only re-runs when the lockfile changes, not on every source code change.

@rvelaVenafi rvelaVenafi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

@ndevarapalli-panw

Copy link
Copy Markdown
Contributor Author

Added setup.py range constraints in the third commit to address VC-53626 alongside this fix, since we are already modifying the file.

install_requires converted from exact == pins to >=floor with ceilings only where the upstream library has a history of breaking API changes between majors (cryptography, ruamel.yaml). Minimum versions are identical to the CVE-safe pins already under review. Also added python_requires='>=3.9.2,<4' which was previously absent.

@ndevarapalli-panw ndevarapalli-panw changed the title fix(deps): bump CVE-affected deps [VC-53657] fix(deps): bump CVE-affected deps [VC-53657, VC-53626] Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants