fix(a11y): raise the dashboard stat values to AA on the widget card - #358
Merged
Merged
Conversation
All three coloured stat values fail 1.4.3 in the light theme at -600 — success 4.13, warning 2.01, danger 3.80 — and danger fails in dark too at 4.33. Shades chosen per colour as the lightest that clears AA in both themes rather than picked for uniformity: success and danger move to -700, warning to -800 because -700 is still 3.98 in light. Amber needs a deeper step than the others; that is a property of amber. QA found the success case on vcmp-dev while verifying VCST-5862. The other two are the same defect and went unseen for the same reason it did: the modifier only renders when a widget carries a stat of that kind, so whether it appears depends on the data in front of you. Measured across all three from the live cascade instead.
|
📦 Preview published for commit Install the preview with dist-tag: npm install @vc-shell/framework@pr-358Or pin to the exact commit: npm install @vc-shell/framework@2.6.0-rc.1-pr358.0de0dc2Published packages (dist-tag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA found
.dashboard-stat-item__value--successat 4.13:1 on vcmp-dev while verifying VCST-5862, and correctly noted neither #356 nor #154 touches it.Checking the other two modifiers found the same defect:
-700→ 6.88-800→ 6.22-700→ 6.01Why the shades differ
Each is the lightest step that clears AA in both themes, measured rather than picked for uniformity.
-700leaves warning at 3.98 in light, so amber takes a deeper step — that is a property of amber, not an inconsistency, and the comment in the file says so with the numbers.Why only one of the three was reported
The modifier renders only when a widget carries a stat of that kind, so whether it appears depends on the data in front of you. That is also why my own "after: 0" run on VCST-5862 did not show even the success case — the widgets held no success stat at that moment. QA made the same point about node counts being row-count dependent; the distinct signature is the stable unit, not the node total.
Measured from the live cascade by forcing each modifier, rather than waiting for data to produce them.
Verification
vue-tscclean ·vitest run4158 passed, exit 0 ·lint:check, prettier and stylelint clean. Browser sweep of all three modifiers in both themes, all six combinations clearing AA.Committed with
--no-verify: the pre-commit hook lints only the staged files, and that narrow invocation reports a falseimport/no-unresolvedthe fulllint:checkdoes not.Contributes to VCST-5862