Codex/fix sankey glyph state - #2129
Merged
Merged
Conversation
skie1997
reviewed
Sep 16, 2026
Comment on lines
+119
to
+122
| if (forceUpdateTag || category & UpdateCategory.SHAPE) { | ||
| child.addUpdateShapeAndBoundsTag(); | ||
| } else if (category & UpdateCategory.BOUNDS) { | ||
| child.addUpdateBoundTag(); |
Contributor
There was a problem hiding this comment.
[P1] 修改 path/radius 后，子图形仍使用旧缓存
子图形继承宿主的 path/radius 时，修改宿主属性不会刷新子图形的几何缓存。例如路径宽度从 10 改成 30，包围盒仍是 10。这里需要更新子图形的几何和包围盒，不能只标记重绘。
Comment on lines
+1018
to
+1020
| if (this.glyphHost) { | ||
| this.commitBaseAttributesByCategory(params, forceUpdateTag, context); | ||
| return; |
Contributor
There was a problem hiding this comment.
[P2] 设置 dx/dy 后，子图形的位移缓存没有更新
给已有变换缓存的 Glyph 子图形执行 setAttributes({ dx: 20 })，属性变成 20，但矩阵中的位移仍是 0。dx/dy 被误判为仅重绘，需要补上变换矩阵和包围盒更新。
xile611
force-pushed
the
codex/fix-sankey-glyph-state
branch
from
September 16, 2026 09:28
880cc3c to
de63027
Compare
skie1997
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough