fix(components): initialize brush mask with computed points - #2131
Merged
Merged
Conversation
Compute rect and axis brush geometry on the first pointer move so the initial mask is a closed rectangle. Preserve polygon trajectories and draw event timing. Validation: 9 targeted tests; all 127 component tests; component typecheck; scoped ESLint. All 16 source-based browser scenarios passed. All four rows of the original VChart case showed rectangular initial strokes and correct zoom ranges: 36 strokes, no diagonals.
skie1997
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute rect and axis brush geometry on the first pointer move so the initial mask is a closed rectangle. Preserve polygon trajectories and draw event timing.
Validation: 9 targeted tests; all 127 component tests; component typecheck; scoped ESLint. All 16 source-based browser scenarios passed. All four rows of the original VChart case showed rectangular initial strokes and correct zoom ranges: 36 strokes, no diagonals.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough