feat: add isolated manual Bug Server runs for reviewed PRs - #2134
Merged
Merged
Conversation
skie1997
approved these changes
Sep 17, 2026
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainers can manually run Bug Server for a reviewed PR, including fork PRs, by providing its number and full head SHA. They first wait for Bug Server PR Bundle to succeed, then run Bug Server CI from the default branch.
The PR-only workflow builds the exact head with read-only repository permissions and no Bug Server secret. The manual workflow never builds or executes PR code: it validates the current head and the artifact's workflow, event, repository, branch and SHA, downloads that immutable artifact, and submits its
index.jsbytes using the trusted default-branch client. ZIP paths and links cannot overwrite the client. Artifacts expire after 7 days; rerun the PR bundle workflow when needed.This removes untrusted execution from the default-branch cache context. The superseded manual build job,
cache-modesetting and runtime guard have been removed. Workflow permissions default tocontents: read; the manual jobs request only the additional read permissions needed for PR/artifact lookup.Validation
dac694ecd, CodeQL passed, with no new alerts. Both cache-poisoning alert #45 and missing-permissions alert #46 are marked fixed, without dismissals or disabled rules.10483685493; safe extraction produced a 3,210,456-byte bundle. The trusted client uploaded those exact bytes to a local mock API; success, photo-failure and missing-token cases passed. Downloaded JavaScript was never executed locally.The README, design notes, execution record and existing Lark maintenance document describe the new workflow and artifact recovery steps.