squeezimize: fix default behavior - #3106
Merged
Merged
Conversation
The default behavior was broken since commit `3b6d5d5286265a58e784e18c1ece5ea867295c52`, where minimize_target (the function input) was being used for calculations instead of using this->minimize_target (the member of the class that stores the final target).
Member
|
@dkondor ping on this, can you have a look? |
Contributor
|
Hi, I don't have time to test this right now, but looking into the change and the original commit, it was likely an oversight from me not to use Note: I think the problematic behavior only occurs if no client (taskbar / dock) sets a minimize location, since this is the only case when |
Member
|
@dkondor Thanks. Just by looking, I arrived at the same conclusions. It seems this patch is rightfully doing what the commit message says. @hustlerone Thanks for your pull request. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior was broken since commit
3b6d5d5286265a58e784e18c1ece5ea867295c52, where minimize_target (the function input) was being used for calculations instead of using this->minimize_target (the member of the class that stores the final target).As of now (without this PR), if you run squeezimize you will see it will not squeeze into anything, it'll just float around then pop out of existence.