chore: bump danger-swift to 3.23.0 (fixes Xcode 27 swiftbuild module lookup) - #264
Merged
Merged
Conversation
3.23.0 fixes module lookup picking the wrong SwiftPM build layout (#663), which breaks Dangerfile evaluation under Xcode 27's `swiftbuild` build system with `no such module 'Danger'` (the runner hardcoded `.build/debug/Modules`). It also moves its own images to newer Node. There are no API or dependency changes versus 3.20.2 (identical Package.swift), so existing consumers are unaffected. - Package.swift: from: "3.20.2" -> "3.23.0" - Package.resolved: pin danger-swift at 3.23.0 - danger-swift: replace the runner with the 3.23.0 universal release binary � Generated with [OpenCode](https://opencode.ai)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
danger-swiftfrom 3.20.2 to 3.23.0.Why
danger-swift 3.20.2's runner hardcodes the SwiftPM module search path to
.build/debug/Modules. Xcode 27's SwiftPM defaults to the newswiftbuildbuild system, which emits module files flat in.build/debug, so evaluating the Dangerfile fails with:3.23.0 fixes exactly this by probing for the actual
Danger.swiftmoduleartifact instead of relying on the compiler that builtdanger-swift(danger/swift#663).Compatibility
No API or dependency changes versus 3.20.2 — the two
Package.swiftfiles are identical apart from the version, and 3.23.0's other changes are Node/danger-js fixes in its own Docker/CI images. Projects pinning an older submodule revision are unaffected; those that pick up this revision just get a more robust runner.Changes
Package.swift:from: "3.20.2"->from: "3.23.0"Package.resolved:danger-swiftpinned to 3.23.0 (36e90f07244dcd5e0870803cfa6e60dd5f58457d)danger-swift: replaced with the officialdanger-swift-macos-universal3.23.0 release binaryTesting
./danger-swift --version->3.23.0swift build --product DangerDepssucceeds against Xcode 27 / Swift 6.4