Make exact and non-exact heap types the same case - #106
Merged
Conversation
Previously the definition of `heaptype` was `... | EXACT typeuse | typeuse`, but this made it impossible to treat the exactness as a variable. Refactor the definition to `... | _HT exact? typeuse` instead. This is similar to how nullability is treated in reference types, except that the `_HT` tag will not be displayed in the rendered spec.
Member
Author
|
The only problem with this is that non-exact references now render with extra parentheses, e.g. |
Member
Author
|
I figured out the parentheses. This should be good to go. |
rossberg
approved these changes
Jul 22, 2026
rossberg
left a comment
rossberg
left a comment
Member
There was a problem hiding this comment.
Right, parens are suppressed around element sequences whose first elements are hidden atoms.
The hack to suppress rendering of parens in other cases is to abuse double escape parens for grouping, i.e., write $($(...)) instead of (...).
|
|
||
| rule Heaptype_ok/exact: | ||
| C |- EXACT typeuse : OK | ||
| C |- _HT exact? typeuse : OK |
Member
There was a problem hiding this comment.
Use the keyword directly in rules where there's no need to name it (e.g., because it is co-iterated multiple times).
Suggested change
| C |- _HT exact? typeuse : OK | |
| C |- _HT EXACT? typeuse : OK |
Comment on lines
+166
to
+168
| def $unrollht(C, _HT exact? deftype) = $unrolldt(deftype) | ||
| def $unrollht(C, _HT exact? _IDX typeidx) = $unrolldt(C.TYPES[typeidx]) | ||
| def $unrollht(C, _HT exact? REC i) = C.RECS[i] |
Member
There was a problem hiding this comment.
Suggested change
| def $unrollht(C, _HT exact? deftype) = $unrolldt(deftype) | |
| def $unrollht(C, _HT exact? _IDX typeidx) = $unrolldt(C.TYPES[typeidx]) | |
| def $unrollht(C, _HT exact? REC i) = C.RECS[i] | |
| def $unrollht(C, _HT EXACT? deftype) = $unrolldt(deftype) | |
| def $unrollht(C, _HT EXACT? _IDX typeidx) = $unrolldt(C.TYPES[typeidx]) | |
| def $unrollht(C, _HT EXACT? REC i) = C.RECS[i] |
| rule Heaptype_sub/exact-l: | ||
| C |- EXACT typeuse <: heaptype | ||
| -- Heaptype_sub: C |- typeuse <: heaptype | ||
| C |- _HT exact typeuse <: heaptype |
Member
There was a problem hiding this comment.
Suggested change
| C |- _HT exact typeuse <: heaptype | |
| C |- _HT EXACT typeuse <: heaptype |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the definition of
heaptypewas... | EXACT typeuse | typeuse, but this made it impossible to treat the exactness as a variable. Refactor the definition to... | _HT exact? typeuseinstead. This is similar to how nullability is treated in reference types, except that the_HTtag will not be displayed in the rendered spec.