Skip to content

Support startAutomatically url param#201

Merged
camillobruni merged 1 commit into
WebKit:mainfrom
camillobruni:2025-10-14_startAutomtaically
Oct 22, 2025
Merged

Support startAutomatically url param#201
camillobruni merged 1 commit into
WebKit:mainfrom
camillobruni:2025-10-14_startAutomtaically

Conversation

@camillobruni

Copy link
Copy Markdown
Contributor

Set startDelay to 100ms if we have startAutomatically enabled.

@camillobruni camillobruni requested a review from danleh October 14, 2025 16:53
@netlify

netlify Bot commented Oct 14, 2025

Copy link
Copy Markdown

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 4b961a1
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68ee8005e24f3200083aec73
😎 Deploy Preview https://deploy-preview-201--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kmiller68

kmiller68 commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Why not just pass startDelay=100 in your CI? Seems like there's not a lot of value of startAutomatically anyway, startAutomatically=1 is not even shorter than startDelay=100.

@camillobruni

Copy link
Copy Markdown
Contributor Author

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion either way: Keeping it consistent with Speedometer vs. simpler without startAutomatically, so LGTM.

@camillobruni camillobruni merged commit c9c4f3d into WebKit:main Oct 22, 2025
10 checks passed
@camillobruni camillobruni deleted the 2025-10-14_startAutomtaically branch October 22, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants