[codex] add FIFO account wait queue#4085
Open
xtyooo wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
xtyooo
force-pushed
the
codex/fifo-account-wait-queue
branch
from
July 12, 2026 05:23
54fe0d3 to
8d6892a
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
xtyooo
marked this pull request as ready for review
July 12, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The previous account wait path only counted waiters and let every request compete to acquire a slot. That allowed later requests to overtake earlier requests and caused avoidable slot-acquisition pressure during bursts.
This first slice makes admission order deterministic and bounds stale waiters. Waiters still use the existing exponential-backoff polling loop, but only the FIFO head performs the account-slot acquisition attempt; event-driven wakeups can be added in a follow-up without changing the queue contract.
Validation
go test ./internal/handler ./internal/service ./internal/repository -count=1go test -tags integration ./internal/repository -run TestConcurrencyCacheSuite/TestAccountWaitQueue -count=1git diff --checkThe queue is optional so existing cache implementations and test doubles retain the legacy behavior.