Excerpt: Honor the visibility block support when generating excerpts.#12167
Excerpt: Honor the visibility block support when generating excerpts.#12167t-hamano wants to merge 2 commits into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Blocks hidden via the `blockVisibility` metadata are stripped from rendered content because `do_blocks()` runs them through the `render_block` filter, where `wp_render_block_visibility_support()` returns an empty string. Excerpt generation bypasses that filter: `wp_trim_excerpt()` unhooks `do_blocks` and instead walks the parsed blocks via `excerpt_remove_blocks()`. Wrapper blocks (group, columns, column) are handed to `_excerpt_render_inner_blocks()`, which renders their inner blocks directly and never evaluates the wrapper's own visibility, so a hidden wrapper's content leaked into the excerpt. Skip blocks whose `blockVisibility` metadata is `false` in both `excerpt_remove_blocks()` and `_excerpt_render_inner_blocks()` so the excerpt matches the rendered content. Co-Authored-By: Claude <noreply@anthropic.com>
t-hamano
force-pushed
the
65456-visibility-excerpt
branch
from
210abfb to
c0ae630
Compare
Viewport visibility (e.g. `blockVisibility.viewport.desktop = false`) only toggles the rendered display via CSS and does not fully hide the block. The excerpt strip logic intentionally matches only the strict `blockVisibility === false` case, so viewport-hidden blocks must remain in the excerpt. Add a test to lock in that behavior. Co-Authored-By: Claude <noreply@anthropic.com>
1 participant
Trac ticket: https://core.trac.wordpress.org/ticket/65456
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Investigating the excerpt rendering path, implementing the fix, and drafting the tests. All changes were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.