Skip to content

HTML API: Treat </br> as tag opener in more places#9657

Open
sirreal wants to merge 9 commits into
WordPress:trunkfrom
sirreal:63891/br-close-open-tag-attributes-return-array
Open

HTML API: Treat </br> as tag opener in more places#9657
sirreal wants to merge 9 commits into
WordPress:trunkfrom
sirreal:63891/br-close-open-tag-attributes-return-array

Conversation

@sirreal

@sirreal sirreal commented Aug 28, 2025

Copy link
Copy Markdown
Member

</br> gets special treatment in the HTML standard. It creates a BR element with no attributes (regardless of whether it appears to have attributes in the HTML like </br attr-name>).

  • Stop on </br> in ::next_tag() like other openers.
  • Return array() from ::get_attribute_names_with_prefix() on </br> instead of null like true close tags.
  • Add tests.

To do:

  • Ensure </br> works with functions like ::set_attribute() and ::add_class(). These will require rewriting the tag to <br attrs …> or the attributes will be discarded.

Trac ticket: https://core.trac.wordpress.org/ticket/65372


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 28, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal sirreal requested a review from dmsnell August 28, 2025 14:19
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61197
GitHub commit: 03171e1

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Nov 10, 2025
@dmsnell

dmsnell commented Nov 12, 2025

Copy link
Copy Markdown
Member

@desrosj looks like this is another victim of over-eager bots closing work that wasn’t merged. this patch was related to the Core ticket mentioned in the SVN commit, but the actual changeset was orthogonal to it.

@dmsnell dmsnell reopened this Nov 12, 2025
@sirreal

sirreal commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Moved to trac ticket https://core.trac.wordpress.org/ticket/65372, this has been appearing in fuzz testing. I added a to-do, this likely needs some extra work to handle attribute modification. It will basically need to rewrite the entire token span I think because any attribute-like syntax needs to be removed before rewriting to <br> and only then can attributes be added.

I would like to move this forward when those issues are handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants