Fix failing tests and version solving in test fixtures - #198
Open
robbecker-wf wants to merge 2 commits into
Open
Fix failing tests and version solving in test fixtures#198robbecker-wf wants to merge 2 commits into
robbecker-wf wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
robbecker-wf
commented
Sep 12, 2026
|
|
||
| unit-tests: | ||
| uses: Workiva/gha-dart-oss/.github/workflows/test-unit.yaml@v0.1.14 | ||
| uses: Workiva/gha-dart-oss/.github/workflows/test-unit.yaml@rob/fix-skipped-tests-fallback |
Member
Author
There was a problem hiding this comment.
TODO will update this once a real release of gha-dart-oss happens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Several unit tests in
executable_test.dartwere failing:analyzerwarning test failed becauseignoredPackageswas subtracted fromunusedDependenciesbefore checking ifanalyzerwas depended on, causing the warning to be skipped whenanalyzerwas ignored.dart_style: ^2.3.2,build_runner: ^2.3.3,build_vm_compilers: ^1.0.3) incompatible withanalyzer >=7.1.0 <15.0.0.Changes
lib/src/dependency_validator.dart, maintainrawUnusedDependenciesbefore strippingignoredPackagesso the warning for depending onanalyzerwithout using it is still emitted whenanalyzeris inignoredPackages.test/executable_test.dart, relaxbuild_runner,coverage,dart_style,build_test, andbuild_web_compilerstohostedAnyin tests checking executables/builders, and replace obsoletebuild_vm_compilerswithjson_serializable(which provides an auto-applied builder).Testing/QA Instructions
dart testto confirm all 97 tests pass.Made with Cursor