Conversation
5a7dfc4 to
070b672
Compare
|
Please verify all the definitions by reading through the references. To what extent did you test the rest of the code? |
070b672 to
5ed0d55
Compare
5ed0d55 to
50d0892
Compare
|
Hey! Sorry, I should've checked the register definitions. If even this an LLM can't get right... 😄 I pushed the revised registers. The interrupt function changes I tested in my flight controller firmware where I use interrupts to schedule tasks. There was quite an annoying bug a while ago because of the rwm in the interrupt pend functions where some tasks wouldn't get scheduled because the interrupt wouldn't get reliably pended. The |
|
FWIW, I didn't find any issues, when I read:
I take it to mean "I have not validated this, nor do I want to be accountable if it's wrong". And that's why I asked you to review them. It's okay for PRs to be less than perfect, a work in progress, or a process of collaboration. It's not okay for them to be low effort. I'm pretty busy with SYCL, I'll have more time to review this once it's done. |
|
No rush :) Btw well done on the badge, I hear it's pretty cool. |
oroperation doing a rmw which was unnecessary and not atomic