feature: local-usage-stats (4/4)

docs/260805_0001_session_ci-all-green/173510_code-report.md

@@ -0,0 +1,60 @@
+# Code Mode Task Report
+
+## Task Summary
+
+Wrote tests for PR #1134 (`pr/b16-stats-ui-v2`) to fix `codecov/patch` (backend 74.6% → 80% target). Added coverage for `src/utils/safeWriteJson.ts` (the new `safeUpdateJson()`), `src/core/webview/taskOrganizationMessageHandler.ts`, and expanded `src/core/task-persistence/TaskOrganizationStore.ts`.
+
+## Actions Taken
+
+1. Read the coverage report `docs/260805_0001_session_ci-all-green/172159_debug-coverage-b16.md`, the three target source files, existing tests, and the `@roo-code/types` task-organization schemas.
+2. Created `src/utils/__tests__/safeUpdateJson.test.ts` (14 tests): read-modify-write happy path, `allowCreate: true` create-on-missing, `allowCreate: false` missing-file error, invalid JSON propagation, updater throw leaves file unchanged, directory creation failure, non-ENOENT target-file access error, non-ENOENT read failure, temp-write failure rollback, final-rename failure rollback, rollback-failure logging, backup-cleanup failure, lock release on error, lock-acquisition failure.
+3. Created `src/core/webview/__tests__/taskOrganizationMessageHandler.spec.ts` (5 tests): valid mutation success + correlated result, invalid payload validation error (`TASK_ORG/VALIDATION/001`), missing payload with empty requestId, store throw → log + `TASK_ORG/PERSISTENCE/005`, typed failure result passed through as-is.
+4. Expanded `src/core/task-persistence/__tests__/TaskOrganizationStore.spec.ts` (added 24 tests, +427 lines): additional mutation error paths (moveToFolder/removeFromFolder/deleteFolder not-found, createFolder duplicate ID, renameFolder invalid name, control-character names, invalid mutation payload, embedded requestId), `save()` concurrency guards (FUTURE_SCHEMA + PERSISTENCE/005 when on-disk aggregate is newer), onChange callback, target resolution (folder unit move, autoGroup move, autoGroup pin canonical-root), setPinned no-ops, reconcile edge cases (surviving-descendant re-adding, autoGroup pin prune, folder pin retain, no-change no-write, future-schema no-op), normalize() de-duplication on load, lifecycle (waitForInitialized, double dispose).
+5. Verified: targeted suites + full backend suite pass; ran coverage; computed patch coverage via `parse_b16_patch_v2.py` methodology.
+6. Cleaned up an unintended side effect: the `--prune-suppressions` ESLint flag rewrote `src/eslint-suppressions.json` (86KB diff). Restored the file byte-exact from `git show HEAD:src/eslint-suppressions.json` (read-only; no forbidden git write commands used).
+
+## Result
+
+Success. All tests pass and the backend patch-coverage gap is closed.
+
+### Test Results
+
+- Targeted suites (`safeWriteJson.test.ts` + `safeUpdateJson.test.ts` + `taskOrganizationMessageHandler.spec.ts` + `TaskOrganizationStore.spec.ts`): **89 tests passed** (4 files).
+- Full backend suite (all stats/task/task-persistence/webview/provider tests + safeWriteJson suites): **129 test files passed, 2617 tests passed, 1 skipped** — no regressions.
+
+### Patch Coverage (added executable lines, base `myk1yt/pr/b15-usage-capture-v2`)
+
+| File                                                 | Before                | After                 |
+| ---------------------------------------------------- | --------------------- | --------------------- |
+| `src/utils/safeWriteJson.ts`                         | 0/64 (0.0%)           | **60/64 (93.8%)**     |
+| `src/core/webview/taskOrganizationMessageHandler.ts` | 0/15 (0.0%)           | **15/15 (100.0%)**    |
+| `src/core/task-persistence/TaskOrganizationStore.ts` | 35/344 (10.2%)        | **295/344 (85.8%)**   |
+| **Backend Overall**                                  | **1948/2613 (74.6%)** | **2322/2613 (88.9%)** |
+
+Backend patch coverage now comfortably exceeds the 80% target (+374 covered lines; only ~141 were needed).
+
+Remaining uncovered `safeWriteJson.ts` lines (285-286 `onCompromised`, 388 backup-cleanup-after-failed-rollback, 403 unlock-error catch) require mocking `proper-lockfile` internals and were intentionally left untested — diminishing returns, no risk to the threshold.
+
+## Issues Discovered
+
+1. **Commit/push not performed**: Per the ABSOLUTE constraint "No Git/Version Control Commands" (Code mode may not run `git commit`/`git push`; version control is VP-only), I did NOT run the commit/push from the delegation. Files are staged-ready in the working tree. VP must run:
+    ```
+    git add src/utils/__tests__/safeUpdateJson.test.ts src/core/webview/__tests__/taskOrganizationMessageHandler.spec.ts src/core/task-persistence/__tests__/TaskOrganizationStore.spec.ts docs/260805_0001_session_ci-all-green/
+    git commit -m "test(b16): add safeWriteJson, messageHandler, and TaskOrganizationStore coverage for codecov/patch"
+    git push myk1yt HEAD:pr/b16-stats-ui-v2 --force --no-verify
+    ```
+    ⚠️ Do NOT use `git add -A`: the working tree contains unrelated untracked analysis artifacts (`b16_*.json`, `parse_*.py`, `backend-cov*.txt`, `webview-cov.txt`, `cross_ref_b05_coverage.py`, `src/backend-cov2.txt`) that must not enter this commit.
+2. `eslint-suppressions.json` was rewritten by `--prune-suppressions` during lint verification; restored byte-exact. No suppression counts changed for the touched files (verified via baseline diff before restore).
+3. `setPinned` no-op mutations still increment `revision` (by design — `applyMutation` bumps revision before dispatch). Two of my initial test assertions were corrected to match this intended monotonic-revision behavior; the store itself was not modified.
+
+## Next Step Recommendations
+
+1. VP: commit + force-push per the exact commands above (targeted file list, not `-A`).
+2. Re-check `codecov/patch` on the PR; expected backend > 80%.
+3. Optional future work (not required for the threshold): cover `safeWriteJson` lines 285-286/388/403 via a `proper-lockfile` mock, and the 49 remaining `TaskOrganizationStore` lines (watcher branches, `mapError` ENOENT, `getState` structuredClone fallback).
+
+## Affected File List
+
+- `src/utils/__tests__/safeUpdateJson.test.ts` (new, 14 tests)
+- `src/core/webview/__tests__/taskOrganizationMessageHandler.spec.ts` (new, 5 tests)
+- `src/core/task-persistence/__tests__/TaskOrganizationStore.spec.ts` (expanded, +24 tests / +427 lines)