[Accton] modules: extract accton_ipmi_intf into common kernel-module … - #212
Open
eric271110 wants to merge 2 commits into
Open
[Accton] modules: extract accton_ipmi_intf into common kernel-module …#212eric271110 wants to merge 2 commits into
eric271110 wants to merge 2 commits into
Conversation
Move accton_ipmi_intf.{c,h} into a single shared location under
packages/platforms/accton/x86-64/common/modules/src/ and reference it
from each platform's kmodule Makefile via KINCLUDES / KMODULES, so each
platform no longer maintains its own copy of the IPMI interface source.
The two prototypes in accton_ipmi_intf.h (init_ipmi_data,
ipmi_send_message) are marked __attribute__((weak)) so modpost does not
report them as undefined during the per-.c isolated build pass. The
symbols are still exported by accton_ipmi_intf.ko and resolved at
insmod time. The same weak-extern pattern is applied to the cross-.ko
symbols referenced by x86-64-accton-as9817-64-fpga.c
(cpld_access_lock, wait_spi, spi_post_write_guard_delay_us,
spi_busy_reg), which are exported by x86-64-accton-as9817-64-i2c-ocores.ko.
Per-platform accton_ipmi_intf.{c,h} copies and their src/Makefile
wrappers are removed.
Affected platforms:
- as7535-28xb
- as7926-40xfb
- as7946-30xb
- as7946-74xkb
- as9737-32db
- as9817-64d
- as9817-64o
- as9926-24db
Signed-off-by: Eric Yang <eric_yang@accton.com>
eric271110
force-pushed
the
move_ipmi_to_common_linux_6.1
branch
from
September 1, 2026 08:42
7670da1 to
b8bca21
Compare
Place the shared IPMI interface helper under packages/platforms/accton/x86-64/modules/builds/ipmi/ to match the existing shared-module layout used elsewhere in this tree (for example, the ptp helper). The previous common/ subtree is no longer needed and is removed. Update KINCLUDES / KMODULES in each affected platform's kmodule Makefile to reference the new path. Affected platforms: - as7535-28xb - as7926-40xfb - as7946-30xb - as7946-74xkb - as9737-32db - as9817-64d - as9817-64o - as9926-24db Signed-off-by: Eric Yang <eric_yang@accton.com>
eric271110
force-pushed
the
move_ipmi_to_common_linux_6.1
branch
from
September 2, 2026 03:02
811bec2 to
5889c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…source tree
Platforms: as7535-28xb, as7926-40xfb, as7946-30xb, as7946-74xkb, as9737-32db, as9817-64, as9926-24db.