Skip to content

Add comprehensive test coverage & Protect credentials file permissions for cbrain_cli #48

Merged
dlq merged 3 commits into
aces:mainfrom
RafsanNeloy:Unit_test
Jul 1, 2026
Merged

Add comprehensive test coverage & Protect credentials file permissions for cbrain_cli #48
dlq merged 3 commits into
aces:mainfrom
RafsanNeloy:Unit_test

Conversation

@RafsanNeloy

Copy link
Copy Markdown
Contributor

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I ran pre-commit run --all-files and/or pytest as appropriate (see Tests in the README). A clean Ruff/pre-commit run is necessary but not sufficient—behavior still needs tests and review.
  • If CLI output changed intentionally, I updated capture_tests/expected_captures.txt
  • If command behavior changed, I checked normal, --json, and --jsonl output modes (or noted why not applicable)
  • Data-layer modules do not add direct print() calls for user-visible output
  • Public command names, flags, and default behavior remain compatible unless this PR explicitly documents a breaking change
  • No credentials, tokens, or session data appear in code, fixtures, logs, or this PR description

Type of change

  • Bug fix
  • New feature or command behavior
  • Documentation
  • Tests only
  • Other (describe below)
    Protect credentials file permissions

Description

This PR fixes task 9 and task 11 from plan.md. Added credential management for file permission also added pytest test coverage for the CLI.


Test plan

pytest --cov=cbrain_cli --cov-report=term-missing

Related issue

-Partially Closes #47

@dlq

dlq commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I removed calling lint twice in two workflows - but otherwise this looks good!

@dlq dlq merged commit 36f52f2 into aces:main Jul 1, 2026
3 checks passed
@RafsanNeloy RafsanNeloy mentioned this pull request Jul 1, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase 2 Progress Tracker

2 participants