Skip to content

dist: Support Tencent Kona JDK#672

Open
johnshajiang wants to merge 1 commit into
actions:mainfrom
johnshajiang:support-kona-jdk
Open

dist: Support Tencent Kona JDK#672
johnshajiang wants to merge 1 commit into
actions:mainfrom
johnshajiang:support-kona-jdk

Conversation

@johnshajiang

@johnshajiang johnshajiang commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Description:
This PR adds Tencent Kona JDK into setup-java.
It supports the major versions 8, 11, 17 and 21.
The supported platforms are Linux x86_64/aarch64, macOS x86_64/aarch64 and Windows x86_64.

Currently, only the latest stable releases are supported, and only jdk (no jre) binaries are available.
A configuration maintains these releases.

Related issue:
#671

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@johnshajiang

Copy link
Copy Markdown
Contributor Author

I just refreshed the commit.
It resolved the file conflicts and supported Tencent Kona JDK 21.

@johnshajiang

Copy link
Copy Markdown
Contributor Author

I just updated the commit again, and the file conflicts are resolved.

@johnshajiang johnshajiang force-pushed the support-kona-jdk branch 3 times, most recently from 41ce0ca to 109744b Compare February 13, 2025 08:31
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 13, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
Signed-off-by: John Jiang <johnsjiang@tencent.com>
@johnshajiang

johnshajiang commented Feb 13, 2025

Copy link
Copy Markdown
Contributor Author

I already executed npm run build for re-generating the index.js files, and committed them.

> setup-java@4.0.0 build
> ncc build -o dist/setup src/setup-java.ts && ncc build -o dist/cleanup src/cleanup-java.ts

ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
5204kB  dist/setup/index.js
5204kB  [2160ms] - ncc 0.38.1
ncc: Version 0.38.1
ncc: Compiling file index.js into CJS
ncc: Using typescript@5.3.3 (local user-provided)
3777kB  dist/cleanup/index.js
3777kB  [1804ms] - ncc 0.38.1

But Check dist check task always failed.

johnshajiang added a commit to johnshajiang/actions-setup-java that referenced this pull request Feb 14, 2025
Signed-off-by: John Jiang <johnsjiang@tencent.com>
@brunoborges brunoborges added feature request New feature or request to improve the current logic distribution JDK distribution/version/source support and removed feature request New feature or request to improve the current logic labels Jun 22, 2026
@brunoborges

Copy link
Copy Markdown
Contributor

Linking the tracking issue: this PR implements #671 (Tencent Kona JDK support). Maintainers — adding Closes #671 to the PR description will auto-close the issue on merge.

@brunoborges brunoborges added the stale The issue has been open for a year without any activity label Jun 23, 2026
@brunoborges brunoborges changed the title Support Tencent Kona JDK dist: Support Tencent Kona JDK Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distribution JDK distribution/version/source support stale The issue has been open for a year without any activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants