docs: split id-update into upsert vs delete-then-insert strategies#222
Merged
Conversation
The delete_all recipe isn't obsolete — it's a different tool (DB-agnostic, validation-friendly, full-row replace). Present both approaches with their trade-offs and lead with the native :on_duplicate_key_update upsert, trimming the adapter notes to the PG/SQLite vs MySQL option shapes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #220.
The "Update existing records by id" README section led with the
delete_allrecipe as the primary way, which reads as if it is outdated next to the native:on_duplicate_key_updateupsert added in #220. It is not — it is a different tool. This restructures the section so the reader can pick the right one::on_duplicate_key_update, single statement, updates only the listed columns. Adapter note trimmed to the two option shapes (PG/SQLite vs MySQL).delete_allrecipe, kept and honestly framed: works on any adapter, lets model validations run, but is a full-row replace plus an extra query.Docs only — no code changes.