fix(csharp): record the #509 revert in the changelog - #673
Open
eric-wang-1990 wants to merge 1 commit into
Open
eric-wang-1990 wants to merge 1 commit into
eric-wang-1990 wants to merge 1 commit into
Conversation
The revert of #509 (PR #672) drops net10.0 support, AOT/trim-safety, and the OpenTelemetry dependency, but the changelog still advertised AOT/trim-safety under [1.1.9] with no note of the revert. Add a [Unreleased] "Removed" entry so the AOT-safety claim is not left standing. Addresses the review on #672. Co-authored-by: Isaac <no-reply@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review on #672.
#672 reverts #509 ("Make the driver AOT/trim-safe under
net10.0"), dropping thenet10.0target, AOT/trim-safety, and the OpenTelemetry dependency (which Power BI cannot take at this time). The changelog still advertised AOT/trim-safety under the released[1.1.9]section with no note of the revert, so a consumer reading it would believe the driver is still AOT/trim-safe and targets net10.0.Adds a
### Removedentry under[Unreleased]recording the revert, so the AOT-safety claim is not left standing unqualified. The released[1.1.9]section is left as-is (it accurately describes what shipped in 1.1.9).This pull request and its description were written by Isaac.