Update supported file formats#845
Draft
Ruchika4 wants to merge 1 commit into
Draft
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restricts accepted file formats per verb to match the defined support matrix, rather than allowing all file types for most conversion verbs.
Changes
unitylibs/core/workflow/workflow-acrobat/limits.jsonallowed-filetypes-no-adobe-design— all formats fromallowed-filetypes-allexcept PSD, AI, and INDDallowed-filetypes-psd-only—image/vnd.adobe.photoshoponlyallowed-filetypes-ai-only—application/illustratoronlyallowed-filetypes-indd-only—application/x-indesignonlyunitylibs/core/workflow/workflow-acrobat/action-binder.jspsd-to-pdf,ai-to-pdf,indd-to-pdf→ each restricted to their own format only (previously accepted all file types)jpg-to-pdf,png-to-pdf,heic-to-pdf,image-to-pdf,bmp-to-pdf,gif-to-pdf,tiff-to-pdf,word-to-pdf,excel-to-pdf,ppt-to-pdf→ switched toallowed-filetypes-no-adobe-design+allowed-filetypes-heic(removes PSD/AI/INDD acceptance, adds HEIC where missing)createpdf(Convert PDF) — unchanged, continues to accept all formatstest/core/workflow/workflow-acrobat/action-binder.test.jsimage-to-pdf verbs onboardingtest block to match new configurationTesting
npm test— 846 passed, 0 failedpsd-to-pdf— only PSD should be acceptedai-to-pdf— only AI should be acceptedindd-to-pdf— only INDD should be acceptedjpg-to-pdf) — should be rejectedword-to-pdf,jpg-to-pdf, etc. — should be acceptedcreatepdf(Convert PDF) — all formats should still be acceptedResolves: MWPW-NUMBER
Test URLs: