PHPStan - Types de retour et corrections associées

sources/Afup/Utils/PDF_AG.php

@@ -10,7 +10,7 @@
 class PDF_AG extends PDF
 {
     public const int CELL_HEIGHT = 7;
-    private $footerTitle = '';
+    private string $footerTitle = '';
 
     /**
      * @param Attendee[] $attendees
@@ -85,12 +85,12 @@ public function Footer(): void
         $this->Cell(0, 10, $this->getFooterTitle() . ' - Page ' . $this->PageNo(), 0, 0, 'C');
     }
 
-    public function getFooterTitle()
+    public function getFooterTitle(): string
     {
         return $this->footerTitle;
     }
 
-    public function setFooterTitle($footerTitle): void
+    public function setFooterTitle(string $footerTitle): void
     {
         $this->footerTitle = $footerTitle;
     }

sources/AppBundle/Accounting/SearchResultProvider.php

@@ -18,8 +18,8 @@ public function __construct(
         private readonly InvoiceRepository $invoiceRepository,
     ) {}
 
-
-    public function getResultsForQuery(string $query)
+    /** @return array<string, mixed> */
+    public function getResultsForQuery(string $query): array
     {
         if ($query === '') {
             return [];

sources/AppBundle/Association/CompanyMembership/AbstractCompanyReminder.php

@@ -24,9 +24,9 @@ public function __construct(
         private readonly SubscriptionReminderLogRepository $subscriptionReminderLogRepository,
     ) {}
 
-    abstract protected function getText();
-    abstract protected function getSubject();
-    abstract protected function getKey();
+    abstract protected function getText(): string;
+    abstract protected function getSubject(): string;
+    abstract protected function getKey(): string;
 
     public function sendReminder(NotifiableInterface $user): void
     {

sources/AppBundle/Association/MembershipReminderInterface.php

@@ -6,5 +6,5 @@
 
 interface MembershipReminderInterface
 {
-    public function sendReminder(NotifiableInterface $user);
+    public function sendReminder(NotifiableInterface $user): void;
 }

sources/AppBundle/Association/UserMembership/AbstractUserReminder.php

@@ -23,9 +23,9 @@ public function __construct(
         private readonly SubscriptionReminderLogRepository $subscriptionReminderLogRepository,
     ) {}
 
-    abstract protected function getText();
-    abstract protected function getSubject();
-    abstract protected function getKey();
+    abstract protected function getText(): string;
+    abstract protected function getSubject(): string;
+    abstract protected function getKey(): string;
 
     public function sendReminder(NotifiableInterface $user): void
     {

sources/AppBundle/Association/UserMembership/SeniorityComputer.php

@@ -15,20 +15,22 @@ class SeniorityComputer
 {
     public function __construct(private readonly MembershipFeeRepository $membershipFeeRepository) {}
 
+    /** @return array{years: int, first_year: int|null} */
     public function computeCompanyAndReturnInfos(CompanyMember $companyMember): array
     {
         $cotis = $this->membershipFeeRepository->getListByUserTypeAndId(MemberType::MemberCompany, $companyMember->getId());
 
         return $this->computeFromCotisationsAndReturnInfos($cotis);
     }
 
-    public function compute(User $user)
+    public function compute(User $user): int
     {
         $infos = $this->computeAndReturnInfos($user);
 
         return $infos['years'];
     }
 
+    /** @return array{years: int, first_year: int|null} */
     public function computeAndReturnInfos(User $user): array
     {
         $cotis = $this->membershipFeeRepository->getListByUserTypeAndId(MemberType::MemberPhysical, $user->getId());
@@ -38,6 +40,7 @@ public function computeAndReturnInfos(User $user): array
 
     /**
      * @param Collection<MembershipFee> $cotisations
+     * @return array{years: int, first_year: int|null}
      */
     private function computeFromCotisationsAndReturnInfos(Collection $cotisations): array
     {
@@ -64,7 +67,7 @@ private function computeFromCotisationsAndReturnInfos(Collection $cotisations):
         $firstYear = null;
 
         if ($years !== []) {
-            $firstYear = min($years);
+            $firstYear = (int) min($years);
         }
 
         return [

sources/AppBundle/Controller/Admin/Event/PricesEditAction.php

@@ -11,6 +11,7 @@
 use AppBundle\Event\Model\Repository\TicketTypeRepository;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 
 class PricesEditAction extends AbstractController
 {
@@ -21,7 +22,7 @@ public function __construct(
         private readonly EventSelectFactory $eventSelectFactory,
     ) {}
 
-    public function __invoke(Request $request, int $event, int $id)
+    public function __invoke(Request $request, int $event, int $id): Response
     {
         $event = $this->eventActionHelper->getEventById($event);
         $ticketType = $this->ticketTypeRepository->get($id);

sources/AppBundle/Controller/Admin/Event/SpeakerInfosAction.php

@@ -7,7 +7,9 @@
 use AppBundle\Controller\Event\EventActionHelper;
 use AppBundle\Event\Model\Repository\SpeakerRepository;
 use AppBundle\Event\Speaker\SpeakerPage;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 
 class SpeakerInfosAction
 {
@@ -17,7 +19,7 @@ public function __construct(
         private readonly SpeakerPage $speakerPage,
     ) {}
 
-    public function __invoke(Request $request)
+    public function __invoke(Request $request): RedirectResponse|Response
     {
         $event = $this->eventActionHelper->getFromRequest('id', false)->event;
         $speaker = $this->speakerRepository->get($request->get('speaker_id'));

sources/AppBundle/Controller/Website/NewsletterController.php

@@ -30,7 +30,7 @@ public function subscribeForm(): Response
         ]);
     }
 
-    public function subscribe(Request $request)
+    public function subscribe(Request $request): Response
     {
         $subscribeForm = $this->getSubscriberType();
         $subscribeForm->handleRequest($request);

sources/AppBundle/Event/Speaker/SpeakerPage.php

@@ -23,6 +23,7 @@
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 
 class SpeakerPage extends AbstractController
 {
@@ -32,7 +33,7 @@ public function __construct(
         private readonly SpeakersExpensesStorage $speakersExpensesStorage,
     ) {}
 
-    public function handleRequest(Request $request, Event $event, Speaker $speaker)
+    public function handleRequest(Request $request, Event $event, Speaker $speaker): Response
     {
         $talks = array_filter(
             iterator_to_array($this->talkRepository->getTalksBySpeaker($event, $speaker)),

sources/AppBundle/Event/Ticket/TicketTypeAvailability.php

@@ -17,7 +17,7 @@ class TicketTypeAvailability
 
     public function __construct(private readonly TicketRepository $ticketRepository) {}
 
-    public function getStock(TicketEventType $ticketEventType, Event $event)
+    public function getStock(TicketEventType $ticketEventType, Event $event): int
     {
         // Les tickets depuis les tokens doivent fonctionner même après le sold out
         if ($ticketEventType->getTicketType()->getTechnicalName() == TicketType::SPECIAL_PRICE_TECHNICAL_NAME) {

sources/AppBundle/Payment/PayboxBilling.php

@@ -66,7 +66,7 @@ public function getCountryCode()
         return $this->countryCode;
     }
 
-    public function getCountryCodeIso3166Numeric()
+    public function getCountryCodeIso3166Numeric(): ?string
     {
         $country = $this->getCountryCode();
 

sources/AppBundle/TechLetter/HtmlParser.php

@@ -90,7 +90,7 @@ public function getMeta($name): ?string
         return $value;
     }
 
-    public function getTitle()
+    public function getTitle(): ?string
     {
         $item = $this->dom->getElementsByTagName('title')->item(0);
         if ($item === null) {