feat: add ACP v1 permission presentation - #405
Open
nikita-ashihmin wants to merge 3 commits into
Open
Conversation
Map Codex approval requests to ACP v1 permission presentation and preserve the provider's real durable choices. Split approval, MCP, metadata, plan review, and presentation logic into focused permission modules with behavioral tests.
nikita-ashihmin
force-pushed
the
codex/acp-v1-permission-metadata
branch
from
August 18, 2026 22:07
4a1f87a to
0c11048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_meta.permissionpresentationTests
npm test(405 passed, 28 skipped)npm run typechecknpm run buildKnown rollout constraint
@openai/codex0.147 generated approval params do not declareavailableDecisions. The adapter validates the runtime field and fails closed withcancelwhen it is absent or malformed rather than inventing choices.