Skip to content

fix: suppress late session updates after close - #418

Merged
Rizzen merged 1 commit into
mainfrom
ignatov/fix-late-session-update-after-close
Aug 20, 2026
Merged

fix: suppress late session updates after close#418
Rizzen merged 1 commit into
mainfrom
ignatov/fix-late-session-update-after-close

Conversation

@ignatov

@ignatov ignatov commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • prevent delayed available command discovery from publishing to a closed session
  • validate session identity, generation, and closing state before publication
  • add a regression test for session/close racing with listSkills

Root cause

session/new starts available command discovery asynchronously. If session/close completes before listSkills returns, the delayed available_commands_update targets a session the ACP client has already removed.

Testing

  • npm run typecheck
  • npm test (438 passed, 28 skipped)
  • npm run bundle:all
  • npm run codex-test -- -p "Reply with exactly OK." -o summary

@Rizzen
Rizzen merged commit ae048a6 into main Aug 20, 2026
6 checks passed
@Rizzen
Rizzen deleted the ignatov/fix-late-session-update-after-close branch August 20, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants