v2 version negotiation + methods - #120
Merged
Merged
Conversation
EugeneTheDev
requested changes
Aug 12, 2026
Rizzen
force-pushed
the
mark/version-negotiation
branch
from
August 12, 2026 14:08
a36ff09 to
b81d26a
Compare
EugeneTheDev
requested changes
Aug 13, 2026
Rizzen
force-pushed
the
mark/version-negotiation
branch
from
August 19, 2026 15:30
b81d26a to
bb4c6c9
Compare
EugeneTheDev
requested changes
Aug 20, 2026
EugeneTheDev
left a comment
EugeneTheDev
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, this looks better now! I like more fundamental v1/v2 split, and I like v2 implementions more, they address some pain poins of the v1 implementation.
I still have some comments though: minor/style ones (starting with "nit", you can ignore them if you want), and a few more fundamental ones, mostly regarding version properties in agent/client and their purpose. Please take a look
Rizzen
marked this pull request as ready for review
August 21, 2026 12:35
EugeneTheDev
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.