fix: scope skills remove to one provider/scope, like skills add - #492
Merged
Conversation
webcmd skills remove previously accepted no --provider/--scope and never prompted: it blind-scanned every provider (agents/codex/claude) and scope (user/project) combination plus the internal stable-link root, removing any matching symlink it found anywhere. Passing an agent name like `codex` had no effect since there was no such flag. skills remove now mirrors skills add: it resolves one provider+scope (or --path) via the same destinationFor() helper, interactively prompting with the same two questions as add when stdin is a TTY and no flags are given. It touches only that single destination per skill and leaves the ~/.webcmd/skills stable links (add/update's concern) alone. Fixes #490. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KuPnjTXhrBoY2KtPV2R89
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webcmd skills removepreviously accepted no--provider/--scopeand never prompted: it blind-scanned every provider (agents/codex/claude) × scope (user/project) combination plus the internal stable-link root, removing any matching symlink it found anywhere. Passing an agent name likecodexhad no effect since there was no such flag.skills removenow mirrorsskills add: resolves one provider+scope (or--path) via the samedestinationFor()helper used by add/update, prompting interactively with the same two questions as add when stdin is a TTY and no flags are given.~/.webcmd/skillsstable links (add/update's concern) are left alone.WebcmdSkillRemoveResultnow reportsprovider/scope, mirroringWebcmdSkillAddResult.Fixes #490.
Test plan
npx vitest run src/skills.test.ts src/cli.test.ts— 180/180 passedplugins/fixture gap present even on a plain checkout, unrelated to this change)npm run typecheck/npm run build— both passskills add --provider codex --scope project --jsonthenskills remove --provider codex --scope project --jsonremoves exactly that symlink; a second remove reportsremoved: [];skills remove --helpshows the new--provider/--scopeflags🤖 Generated with Claude Code
https://claude.ai/code/session_013KuPnjTXhrBoY2KtPV2R89