feat: drop hosted mode from webcmd setup - #493
Merged
Merged
Conversation
webcmd setup no longer asks "hosted or local" or accepts --mode/--api-key. It always configures local browser mode: browser selection, Chrome cookie import, and daemon restart are unchanged. Hosted-mode setup (API key entry, account verification, credential storage) is removed along with its now-dead helpers. Reading an existing on-disk hosted config elsewhere in the CLI (main.ts, hosted/availability.ts, hosted/contract.ts) is untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013KuPnjTXhrBoY2KtPV2R89
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webcmd setupno longer asks "hosted or local" or accepts--mode/--api-key. It always configures local browser mode: browser selection, Chrome cookie import, and daemon restart are unchanged.hostedAccountLabel,credentialBackendLabel).main.ts,hosted/availability.ts,hosted/contract.ts) is untouched — only the ability to create one viasetupis removed.Test plan
src/hosted/setup.test.ts— 39/39 passed (hosted-path tests removed; local-path tests adapted, including a regression test that a mockedquestionanswering'hosted'is never even called in non-interactive mode)plugins/fixture gap present even on a plain checkout, unrelated to this change)npm run typecheck/npm run build— both passsetup --help/setup --statuson the built CLI show no--mode/--api-key, reports{"mode":"local", ...}