tests: Add Fleet and FleetAutoscaler tests - #27
Merged
lacroixthomas merged 12 commits intoAug 2, 2026
Merged
Conversation
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
NAME-ASHWANIYADAV
marked this pull request as draft
June 23, 2026 23:18
Member
|
oh fun more conflicts ohno 😄 |
Contributor
Author
|
@markmandel I resolved the conflict , will appreciate a re-reviw!! |
NAME-ASHWANIYADAV
marked this pull request as ready for review
July 16, 2026 21:13
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
…ASHWANIYADAV/headlamp-plugin into fix/fleet-autoscaler-tests
Member
|
@lacroixthomas you got eyes on this one? I merged a stack of stuff today, but didn't want to step on your reviews. |
Contributor
LGTM ! 👍🏼 |
lacroixthomas
enabled auto-merge (squash)
August 2, 2026 22:30
Member
|
Testing Copilot as a reviewer - I'm curious.... |
There was a problem hiding this comment.
Pull request overview
This PR adds Vitest unit coverage for the Agones Fleet and FleetAutoscaler resource models in the Headlamp plugin, expanding the existing resource-model test suite.
Changes:
- Added a new
Fleetunit test suite covering core getters and newer fields (allocationOverflow/priorities/counters/lists). - Added a new
FleetAutoscalerunit test suite covering core getters plus shape coverage for additional policy variants (Schedule/Wasm/Chain). - Updated the
AgonesFleetAutoscalerTypeScript interface (notably the Wasm policy schema and theschedule.betweenshape).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/resources/fleetautoscaler.ts |
Updates the FleetAutoscaler interface shape (Wasm policy and schedule typing) to support additional fields referenced by tests/upstream. |
src/resources/fleetautoscaler.test.ts |
Introduces a FleetAutoscaler unit test suite validating static fields and key getters, plus policy shape coverage. |
src/resources/fleet.test.ts |
Introduces a Fleet unit test suite validating static fields and key getters, including newer scheduling/allocation-related fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
80
| /** | ||
| * WebAssembly-based autoscaling policy. | ||
| * | ||
| * @see {@link https://agones.dev/site/docs/advanced/scheduling-and-autoscaling/#custom-autoscaler-with-wasm | Wasm Autoscaler} | ||
| * @see {@link https://agones.dev/site/docs/reference/fleetautoscaler/#wasm-autoscaling | Wasm Autoscaler} | ||
| */ | ||
| wasm?: { | ||
| url: string; | ||
| requestsPerSecond?: number; | ||
| /** Exported function to call in the wasm module, defaults to 'scale'. */ | ||
| function?: string; | ||
| /** Config values to pass to the wasm program on startup. */ | ||
| config?: Record<string, string>; | ||
| /** Source of the Wasm module. */ | ||
| from: { | ||
| url?: { | ||
| url?: string; | ||
| service?: { | ||
| name: string; | ||
| namespace: string; | ||
| path?: string; | ||
| port?: number; | ||
| }; | ||
| caBundle?: string; | ||
| }; | ||
| }; | ||
| /** Hex-encoded SHA-256 hash for integrity verification. */ | ||
| hash?: string; | ||
| }; | ||
| schedule?: { | ||
| between?: { | ||
| start: string; | ||
| end: string; | ||
| minReplicas: number; | ||
| maxReplicas: number; | ||
| }; |
Member
There was a problem hiding this comment.
This seems fine - we talked about it above.
markmandel
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What this PR does
Adds comprehensive unit tests for the
FleetandFleetAutoscalerresource models using the Vitest infrastructure introduced in #26.Fleet tests (30 tests):
scheduling,desiredReplicas,currentReplicas,allocatedReplicas,readyReplicas,reservedReplicas,strategy,maxSurge,maxUnavailable,allocationOverflow,priorities,counters,lists.FleetAutoscaler tests (34 tests):
fleetName,policyType,bufferSize,minReplicas,maxReplicas,currentReplicas,desiredReplicas,ableToScale,scalingLimited,lastScaleTime,lastAppliedPolicy,syncInterval.Did you use AI tools in preparing this PR?:
Y
Test plan
Automated checks
npm cinpm run buildnpm run tscnpm run lintnpm run format -- --checknpm run testAll 121 tests pass across 5 test files (GameServer 29, Fleet 30, FleetAutoscaler 34, StateChip 13, buildAllocationBody 15).
Manual verification
N/A - unit tests only.
Notes for reviewers
All test data structures are verified against the upstream Agones Go structs (
fleet.go,fleetautoscaler.goinagones-upstream/pkg/apis/agones/v1/).