fix(input): match a caret's word whole when selecting its occurrences - #5
Merged
Merged
Conversation
The first press with a bare caret selects the word under it. Presses after it now match that word only where it stands whole, as Sublime Text and VS Code do, so the n in `len` is not taken with `n`. A selection made by hand still matches anywhere. The word is remembered with the document revision, so an edit or a different selection ends it. Co-Authored-By: Claude Code
trancong12102
force-pushed
the
feat/occurrence-whole-words
branch
from
October 1, 2026 17:58
26580ab to
09bc77d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first ⌘D with a bare caret selects the word under it. Until now the presses after it matched the text anywhere, so selecting
nalso took theninsidelen. They now match the word only where it stands whole, as Sublime Text and VS Code do. A selection made by hand still matches anywhere.The word a caret selected is kept with the document revision (
occurrence_word). Whole-word matching holds while that selection still stands and the text is unedited.Public API
None. One private field on
InputBaseState.Tests
test_a_word_from_the_caret_matches_whole_words_and_a_selection_anywhere, incrates/base/src/input/base/occurrences.rs.Written with Claude Code (AI-generated).