change prometheus status in hook on state change - #255
Open
thorinaboenke wants to merge 1 commit into
Open
thorinaboenke wants to merge 1 commit into
thorinaboenke wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
#253
Description
Fixes engine_running metric, that kept reporting running after the engine loop thread crashed.
Every engine state change now goes through _set_state(), which calls an _on_state_change() hook, and Service overrides this method to update the metric (STOPPING keeps reporting running, so start()/stop() no longer set it themselves.
How Has This Been Tested?
new unit tests
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.