fix(knowledge): stabilize mutation timestamps - #403
Merged
Merged
Conversation
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Keep candidate-knowledge application timestamps nondecreasing when the wall clock moves backward, preventing valid follow-up mutations from tripping storage anti-rollback validation.
Refs #389. #389 remains open until post-merge validation confirms the main revision.
Evidence
A deterministic one-hour backward-clock case reproduced the previously captured
StorageValidationError:checkedAtpreceded the persisted refresh observation. The regression now passes through a service-local monotonic timestamp source.Scope
Validation
pnpm validate: 105/105 Vitest files, 1,596/1,596 tests, 54/54 release/security testspackages/application/src/knowledge-base.tsremains at 6,168 linesLimitations
This fixes the proven within-service wall-clock regression mechanism. It does not weaken storage anti-rollback checks or claim that every earlier intermittent mutation failure had the same cause.