feat(adapters): support explicit proxy configuration - #51
Merged
Conversation
Add a `proxy` client option that is threaded through to the Faraday, httpx, and net/http adapters. Passing a URI string forces a specific proxy; passing `false` disables proxying (including env-based auto-detection) for a fixed, trusted `base_url`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T1xdiN28Drqsrh3rET88kW
redox
approved these changes
Aug 26, 2026
Contributor
|
Required: the Ruby 3.2 job is still failing. HTTPX exposes an anonymous wrapper class on that runtime, so the assertion on Please replace that class-name assertion with an observable proxy configuration or request-behavior assertion, then rerun CI before merging. |
HTTPX's dynamically generated plugin classes only get a readable
to_s via Class#set_temporary_name, which is Ruby >= 3.4 only. On
Ruby 3.2/3.3 the class stays anonymous, so the proxy spec's
`client.class.to_s.include?("Plugins::Proxy")` assertion always
failed there, breaking CI. Check the client's actual proxy option
instead, which is version-independent.
leonkenneth
pushed a commit
that referenced
this pull request
Aug 27, 2026
🤖 I have created a release *beep* *boop* --- ## [1.2.0](altertable/v1.1.2...altertable/v1.2.0) (2026-08-27) ### Features * **adapters:** support explicit proxy configuration ([#51](#51)) ([309aa8f](309aa8f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxyclient option, threaded through to the Faraday, httpx, and net/http adapters.falsedisables proxying (includingHTTP_PROXY/HTTPS_PROXYenv auto-detection) for a fixed, trustedbase_url.proxyunset preserves each adapter's existing default behavior (Faraday and net/http auto-detect from env; httpx never does).Test plan
bundle exec rspecbundle exec rubocopbundle exec srb tcCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01T1xdiN28Drqsrh3rET88kW